Upgrade master to PHPUnit 8 #9166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first version of phpunit that will work on php 7.4 without patches.
Note that any project will need to do this to work with phpunit 8, but it’s a pretty straightforward regex to do so. The following methods need to have “: void” added: setUp(), tearDown(), setUpBeforeClass(), tearDownAfterClass() It would be useful to build upgrader config for this if possible.
|
Looks like recipe-testing needs a bump too. Sounds good to me though! |
| @@ -110,7 +110,7 @@ use SilverStripe\Dev\SapphireTest; | |||
|
|
|||
| class PageTest extends SapphireTest | |||
| { | |||
| public function setUp() | |||
| public function setUp(): void | |||
There was a problem hiding this comment.
This is the kind of thing that would ideally be able to be automated by the upgrader, since it's going to be very common in modules and projects. Relevant issue: silverstripe/silverstripe-upgrader#175
|
Grr behat-extension also needs a bump. Stupid ball of mud! |
Merged
|
replaced by #9443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version of phpunit that will work on php 7.4 without patches.