Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Don't log to the error handler #11523

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Comment on lines +26 to +27
# Core error handling - only uncaught exceptions and PHP errors should be caught by this handler.
# This handler displays those errors in the browser and CLI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Core error handling - only uncaught exceptions and PHP errors should be caught by this handler.
# This handler displays those errors in the browser and CLI.
# Core error handling - only uncaught exceptions and PHP errors should be caught by this handler.
# This handler displays those errors in the browser and CLI.
# Projects should not attach log handlers to this logging service.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done but I called it an "error handler" service not a "logging" service since it shouldn't be used for logging.

@emteknetnz emteknetnz merged commit 2d472f4 into silverstripe:5 Jan 6, 2025
17 checks passed
@emteknetnz emteknetnz deleted the pulls/5/bad-logging branch January 6, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants