Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pretty name of closures on PHP 8.4 #11264

Closed
wants to merge 2 commits into from
Closed

Conversation

staabm
Copy link

@staabm staabm commented May 25, 2024

Description

related to php/php-src#13550

see analog symfony change: symfony/symfony#54614

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli
Copy link
Member

Hi there, thank you for the contribution.

You've missed several important parts of the pull request description. Please fill out the template in full, including creating an issue to link to, explaining what this change actually does, and ticking the relevant check boxes.

You may find you need to adjust the pull request in order to check some boxes, for example your commit message doesn't match our guidelines.

@staabm
Copy link
Author

staabm commented May 27, 2024

hey.

I am not a silverstripe user and contributed this fix by scanning all over github for this particular problem.
I don't know how to reproduce the issue at hand and I am not willing to invest more time into it.

I am ok with closing the PR in case you are not interessted in the fix.

thank you

@GuySartorelli
Copy link
Member

Thanks for letting us know.
In this case I'll close the PR, as it's not clear what benefit it would provide, if any.

@staabm staabm deleted the patch-1 branch May 28, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants