Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Return null error solved for DBQueryBuilder::shouldBuildTraceComment #11241

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Ofthemasses
Copy link
Contributor

@Ofthemasses Ofthemasses commented May 16, 2024

Description

Solves scenario where DBQueryBuilder::shouldBuildTraceComment returns null, causing a TypeError

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@Ofthemasses
Copy link
Contributor Author

Would you like a test written alongside my changes?

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test needed.
It's weird that this caused a problem given there is a default value set for that config - this code must have been triggered before the config manifest was booted, I guess? Is that even possible?
Anyway, doesn't harm anything so it's probably fine. Just a weird thing to have to do - we won't be adding this for all config everywhere so it's weird to need it here.

@GuySartorelli GuySartorelli merged commit c224a84 into silverstripe:5 Sep 25, 2024
15 checks passed
@Ofthemasses Ofthemasses deleted the patch-1 branch October 1, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants