Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassManifest::validateItemCache always return false #11531

Open
2 tasks done
lekoala opened this issue Jan 7, 2025 · 0 comments
Open
2 tasks done

ClassManifest::validateItemCache always return false #11531

lekoala opened this issue Jan 7, 2025 · 0 comments

Comments

@lekoala
Copy link
Contributor

lekoala commented Jan 7, 2025

Module version(s) affected

5.3

Description

I was suspecting that something was slow on my machine because dev/build was taking ages

During debugging, I saw that my individuals cache entries never contain "enums", eg:

<?php //Tip_php_9d87b488d828b5dd1111c02e4421238d

return [PHP_INT_MAX, [
    'classes' => [
        'SilverStripe\\Forms\\Tip' => [
            'extends' => [],
            'interfaces' => [],
        ],
    ],
    'interfaces' => [],
    'traits' => [],
]];

therefore, validateItemCache is always false, since it checks for enums

How to reproduce

Refresh the manifest
See if the individual cache files contain enum
See that it will never return true because of that

Possible Solution

No response

Additional Context

Also see

https://github.com/silverstripe/silverstripe-framework/issues

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
lekoala added a commit to lekoala/silverstripe-framework that referenced this issue Jan 7, 2025
lekoala added a commit to lekoala/silverstripe-framework that referenced this issue Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant