Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Pass empty string instead of null for error #1311

Merged
merged 1 commit into from
Feb 10, 2025
Merged

FIX Pass empty string instead of null for error #1311

merged 1 commit into from
Feb 10, 2025
+2 −2

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jan 28, 2025
Closed
3 tasks
@emteknetnz emteknetnz force-pushed the pulls/6.0/validation-values branch from ac57361 to 3054af0 Compare January 28, 2025 05:17
@emteknetnz emteknetnz marked this pull request as ready for review January 31, 2025 04:03
GuySartorelli
GuySartorelli approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge when main PR is merged

@GuySartorelli GuySartorelli mentioned this pull request Feb 3, 2025
Merged
@GuySartorelli GuySartorelli merged commit 4c38c0c into silverstripe:6.0 Feb 10, 2025
25 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/validation-values branch February 10, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli