FIX Allow wrapping an image in a link #2883
Merged
+54
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relies on logic added to silverstripe/admin, so we need to bump the constraint as well. Behat test requires new logic added to the behat-extension module.
This was referenced Sep 6, 2023
Merged
GuySartorelli
commented
Sep 6, 2023
Comment on lines
-97
to
-104
| getRequireLinkText() { | ||
| const selection = this.getElement().getEditor().getInstance().selection; | ||
| const selectionContent = selection.getContent() || ''; | ||
| const tagName = selection.getNode().tagName; | ||
| const requireLinkText = tagName !== 'A' && selectionContent.trim() === ''; | ||
|
|
||
| return requireLinkText; | ||
| }, |
There was a problem hiding this comment.
This function is now provided by silverstripe/admin instead
emteknetnz
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on logic added to silverstripe/admin, so we need to bump the constraint as well.
Behat test requires new logic added to the behat-extension module.
Make sure you check the installer CI run linked in the issue to see behat passing happily
Supercedes #2880
Requires
Issue