ENH Add campaign-admin support back in #1548
Draft
+121
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7a25b7 to
c066f14
Compare
c066f14 to
867bd5a
Compare
GuySartorelli
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Just as a sanity check since you haven't provided any information - did you check if this can be done by adding code from the campaign admin module itself?
| @@ -24,6 +25,7 @@ | |||
| use SilverStripe\Assets\Image; | |||
| use SilverStripe\Assets\Storage\AssetNameGenerator; | |||
| use SilverStripe\Assets\Upload; | |||
| use SilverStripe\CampaignAdmin\AddToCampaignHandler; | |||
There was a problem hiding this comment.
Why are we adding this use statement, or the RuntimeException one?
Comment on lines
-215
to
+218
| return array_merge($parentClientConfig, [ | ||
| return ArrayLib::array_merge_recursive($parentClientConfig, [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/895
yarn build failed to run, so will need to fix that up