API Remove code which is being migrated to a new TinyMCE module #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
0efef04 to
c117fa2
Compare
4b16d6e to
a084368
Compare
a084368 to
57c92d8
Compare
GuySartorelli
commented
Mar 6, 2025
| @@ -5,6 +5,7 @@ | |||
| */ | |||
| require('expose-loader?exposes=InsertMediaModal!containers/InsertMediaModal/InsertMediaModal'); | |||
| require('expose-loader?exposes=InsertEmbedModal!components/InsertEmbedModal/InsertEmbedModal'); | |||
| require('expose-loader?exposes=AssetAdminModalActions!state/modal/ModalActions'); | |||
There was a problem hiding this comment.
Needed so it can be used in plugins in the new repo
GuySartorelli
commented
Mar 6, 2025
Comment on lines
-415
to
+429
| // Check if the popover is open for the block | ||
| $button = $modal->find('xpath', "//button[contains(text(), '$buttonName')]"); | ||
|
|
||
| Assert::assertNotNull($button, sprintf('Could not find button labelled "%s"', $buttonName)); | ||
|
|
||
| $button = $this->basicContext->findNamedButton($buttonName, $modal); | ||
| if (!$button) { | ||
| Assert::assertNotNull($button, sprintf('Could not find button labelled "%s"', $buttonName)); | ||
| } |
There was a problem hiding this comment.
The behat tests copied from this repo weren't playing nicely with And I press the "Save" button (it pressed the page save button instead of the modal one).
Updating to And I press the "Save" button inside the modal failed to find the button until this change was made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue