Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Handle extra empty values #1621

Closed
wants to merge 1 commit into from
Closed

FIX Handle extra empty values #1621

wants to merge 1 commit into from

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 8, 2023 •
edited
Loading

Issue #1616

Test setup provided here #1616 (comment)

This was referenced Nov 8, 2023
Closed
Closed
@emteknetnz emteknetnz marked this pull request as draft November 8, 2023 04:00
@emteknetnz emteknetnz marked this pull request as ready for review November 8, 2023 04:13
sabina-talipova
sabina-talipova approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally.

GuySartorelli
GuySartorelli requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems okay to me - though as a bugfix that affects CMS 4 and doesn't add any new API, this should target 1.13, shouldn't it?

@emteknetnz emteknetnz mentioned this pull request Nov 26, 2023
Merged
@emteknetnz
Copy link
Member Author

Closed in favor of #1627

@emteknetnz emteknetnz closed this Nov 26, 2023
@GuySartorelli GuySartorelli deleted the pulls/2.1/treedowndown-required branch November 27, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli requested changes

@sabina-talipova sabina-talipova sabina-talipova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @GuySartorelli @sabina-talipova