ENH Keep State and show Search field if any keywords are presented. #1322
Conversation
c4e9ff1 to
b701ac0
Compare
b701ac0 to
b1d75c2
Compare
| const historyState = $.extend({}, {path: window.location.pathname + searchParam}, this.getState()); | ||
| history.replaceState(historyState, '', window.location.pathname + searchParam); |
There was a problem hiding this comment.
Make sure we're not just throwing away other GET vars that were already present
There was a problem hiding this comment.
Thank you. I'll check parameters that we pass in GridField.php class. Since, here I just grab all search params from scheme, that we also pass to Edit button and as URL for click. So, would be better to be sure that we have a correct value in the scheme.
What do you think?
There was a problem hiding this comment.
This is the URL for the gridfield we're currently looking at - which needs to include any GET parameters that are already in the URL.
So for example if I'm on some page /admin/pages/edit/show/2?some-var=some-value and I click paginate on a gridfield, the some-var=some-value shouldn't be removed. These may be here for any reason beyond gridfield, and removing them may cause problems in some project-specific code that relies on them for whatever reason.
The edit and view buttons don't need these, because they're relevant only while you're on the page that holds the gridfield, not for the item edit form.
b1d75c2 to
c768e97
Compare
Move group tests into a new feature Refactor tests into distinct scenarios
This change adds support for a new global .lazy-loadable selector. Nodes with this class will receive a "lazyload" event to allow them to display content upon tab activation. This also fix lazy-loading not being applied properly inside cms-tabset (they don't have the ss-tabset class).
selector should include cms-tabset, since they don't have the ss-tabset class by default
Co-authored-by: Michal Kleiner <mk@011.nz>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
+ Added the parameter fields created by CMSMain's BatchActionParameters() method to the BatchActionsForm + Added javascript for displaying/hiding parameter fields when the batch action dropdown is changed + Added CSS styles to make the parameter fields render properly under the batch action dropdown
+ Added code to loop over parameter input fields and reset their values to the default before displaying them
+ Replaced the ID `#BatchActionParameters` selector with a `.action-parameters` class selector + Nested `.action-parameters` rules under `.cms-batch-actions`
+ Removed the changes to the BatchActionsForm in favor of using `updateBatchActionsForm()` in an extension
c768e97 to
f135f89
Compare
|
Closed in favor of #1326 |
Description
Parent issue