Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination tests for grid fields to make sure next and previous buttons work #1238

Conversation

bergice
Copy link
Contributor

@bergice bergice commented Jul 8, 2021

Resolves #886

@bergice bergice force-pushed the pulls/1.8/grid-field-tests branch from 976ef02 to 7cdbf5a Compare July 8, 2021 02:56
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behat test is broken

I've left comments on the corresponding PR that attempted to fix this - I've recommend that one be closed so this one probably should be as well

@bergice
Copy link
Contributor Author

bergice commented Jul 9, 2021

Behat test is broken

I've left comments on the corresponding PR that attempted to fix this - I've recommend that one be closed so this one probably should be as well

The behat test is failing as expected because it would depend on another PR in the framework module to pass..

@GuySartorelli
Copy link
Member

Closed in favour of #1338

@GuySartorelli GuySartorelli deleted the pulls/1.8/grid-field-tests branch August 22, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants