BUG Do not override grid state with search parameters

silverstripe · Nov 17, 2020 · 7594ef2 · 7594ef2
1 parent a000151
commit 7594ef2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/client/dist/js/bundle.js b/client/dist/js/bundle.js
diff --git a/client/src/legacy/GridField.js b/client/src/legacy/GridField.js
@@ -274,7 +274,9 @@ $.entwine('ss', function($) {
       }
 
       var formLink = this.find('.edit-link, .view-link');
-      if(formLink.length) this.getGridField().showDetailView(formLink.prop('href'));
+      if(formLink.length) {
+        this.getGridField().showDetailView(formLink.prop('href'));
+      }
     },
     onmouseover: function() {
       if(this.find('.edit-link, .view-link').length) this.css('cursor', 'pointer');

diff --git a/client/src/legacy/LeftAndMain.js b/client/src/legacy/LeftAndMain.js
@@ -1256,10 +1256,6 @@ $.entwine('ss', function($) {
    */
   $('.cms .grid-field:not([cms-loading-ignore-url-params])').entwine({
     showDetailView: function(url) {
-      // Include any GET parameters from the current URL, as the view state might depend on it.
-      // For example, a list prefiltered through external search criteria might be passed to GridField.
-      var params = window.location.search.replace(/^\?/, '');
-      if(params) url = $.path.addSearchParams(url, params);
       $('.cms-container').loadPanel(url);
     }
   });