Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "warning" about "fulltextsearch" #681

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

Firesphere
Copy link
Contributor

@Firesphere Firesphere commented Jan 30, 2025

The "silverstripe-labs" fulltextsearch module is incredibly outdated, and relies on a very outdated not-vendorized library. The security and stability of this module is questionable at best, and should not be suggested

Description

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

The "silverstripe-labs" fulltextsearch module is incredibly outdated, and relies on a very outdated not-vendorized library.
The security and stability of this module is questionable at best, and should not be suggested
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That module had its supported status removed for CMS 5 so makes sense to remove this reference to it. Thanks for submitting.

Might make sense to add a new comment here advising developers to look for third-party modules providing integrations with search services but that can always be done in a follow-up PR.

@GuySartorelli GuySartorelli merged commit 59efc68 into silverstripe:5.3 Feb 2, 2025
4 checks passed
@GuySartorelli
Copy link
Member

Note the commit message was missing the DOC prefix but I added that on merge. Just an FYI for next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants