Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Deprecate passing null paramters for Form and ValidationResult methods #678

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions en/08_Changelogs/5.4.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,17 @@ See [indexes](/developer_guides/model/indexes/) to learn about indexes in Silver
- The [`HTTP.ignoreDeprecatedCaching`](api:SilverStripe\Control\HTTP->ignoreDeprecatedCaching) configuration property has been deprecated. It will be removed without equivalent functionality to replace it.
- [`FormField::Value()`](api:SilverStripe\Forms\FormField::Value()) has been deprecated. It will be replaced by getFormattedValue() and getValue().
- [`TextareaField::ValueEntities()`](api:SilverStripe\Forms\TextareaField::ValueEntities()) has been deprecated. It will be replaced by getFormattedValueEntities().
- Passing `null` for the `$code` parameter in [`ValidationResult::addError()`](api:SilverStripe\ORM\ValidationResult::addError()) is deprecated. Pass a blank string instead.
- Passing `null` for the `$cast` parameter in [`ValidationResult::addError()`](api:SilverStripe\ORM\ValidationResult::addError()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
- Passing `null` for the `$code` parameter in [`ValidationResult::addFieldError()`](api:SilverStripe\ORM\ValidationResult::addFieldError()) is deprecated. Pass a blank string instead.
- Passing `null` for the `$cast` parameter in [`ValidationResult::addFieldError()`](api:SilverStripe\ORM\ValidationResult::addFieldError()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
- Passing `null` for the `$code` parameter in [`ValidationResult::addMessage()`](api:SilverStripe\ORM\ValidationResult::addMessage()) is deprecated. Pass a blank string instead.
- Passing `null` for the `$cast` parameter in [`ValidationResult::addMessage()`](api:SilverStripe\ORM\ValidationResult::addMessage()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
- Passing `null` for the `$code` parameter in [`ValidationResult::addFieldMessage()`](api:SilverStripe\ORM\ValidationResult::addFieldMessage()) is deprecated. Pass a blank string instead.
- Passing `null` for the `$cast` parameter in [`ValidationResult::addFieldMessage()`](api:SilverStripe\ORM\ValidationResult::addFieldMessage()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
- Passing `null` for the `$cast` parameter in [`Form::sessionMessage()`](api:SilverStripe\Forms\Form::sessionMessage()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
- Passing `null` for the `$cast` parameter in [`Form::sessionError()`](api:SilverStripe\Forms\Form::sessionError()) is deprecated. Pass a ValidationResult::CAST_* constant instead.
- Passing `null` for the `$cast` parameter in [`Form::sessionFieldError()`](api:SilverStripe\Forms\Form::sessionFieldError()) is deprecated. Pass a ValidationResult::CAST_* constant instead.

## Bug fixes

Expand Down