Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Document new parameter for DataObject::write() #499

Merged
merged 1 commit into from
Apr 18, 2024
Merged

DOC Document new parameter for DataObject::write() #499

merged 1 commit into from
Apr 18, 2024

Conversation

GuySartorelli
Copy link
Member

Also slightly restructured the changelog to be more like the 5.0.0 one was

Issues

@GuySartorelli GuySartorelli mentioned this pull request Apr 18, 2024
Closed
2 tasks
emteknetnz
emteknetnz requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failure

@GuySartorelli GuySartorelli force-pushed the pulls/6/dataobject-write branch from 28b091c to 13318d2 Compare April 18, 2024 22:37
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Apr 18, 2024 •
edited
Loading

Oops, I could have sworn I saw this go green. Fixed.

@emteknetnz emteknetnz merged commit 77c3210 into silverstripe:6 Apr 18, 2024
3 checks passed
@emteknetnz emteknetnz deleted the pulls/6/dataobject-write branch April 18, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuySartorelli @michalkleiner @emteknetnz