Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Elemental versioned badge #475

Merged
merged 1 commit into from
Mar 12, 2024
Merged

DOC Elemental versioned badge #475

merged 1 commit into from
Mar 12, 2024

Conversation

emteknetnz
Copy link
Member

Issue #474

@emteknetnz emteknetnz mentioned this pull request Mar 11, 2024
Closed
GuySartorelli
GuySartorelli requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a screenshot - if I didn't know what work had been done I'd assume this was talking about the dots that already exist.

@emteknetnz emteknetnz force-pushed the pulls/5.2/elemental-badges branch from 330a83d to e772dac Compare March 11, 2024 23:12
@emteknetnz
Copy link
Member Author

Updated

GuySartorelli
GuySartorelli requested changes Mar 11, 2024
View reviewed changes
@emteknetnz emteknetnz force-pushed the pulls/5.2/elemental-badges branch from e772dac to 9da6a80 Compare March 11, 2024 23:30
GuySartorelli
GuySartorelli approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Won't be in beta changelog but that's not a big deal.

@GuySartorelli GuySartorelli merged commit 02d6a33 into silverstripe:5.2 Mar 12, 2024
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.2/elemental-badges branch March 12, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli