Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update model validation docs #467

Merged
merged 1 commit into from
Apr 15, 2024
Merged

DOC Update model validation docs #467

merged 1 commit into from
Apr 15, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Mar 4, 2024 •
edited
Loading

Issue silverstripe/silverstripe-elemental#329

  • swapped the order of "Model Validation" and "Contraints" to match the page title, and also because it's a more logical order IMO
  • Added an addFieldError() example which I think is the most common use case for using model validation
  • Updated h1 to match page title

@emteknetnz emteknetnz mentioned this pull request Mar 4, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/5/model-validation branch from e6af9ba to 0eb2c37 Compare March 7, 2024 02:54
@GuySartorelli
Copy link
Member

linting failure

@emteknetnz emteknetnz force-pushed the pulls/5/model-validation branch from 0eb2c37 to 801c2c7 Compare March 17, 2024 22:51
@emteknetnz
Copy link
Member Author

Updated

@emteknetnz emteknetnz force-pushed the pulls/5/model-validation branch 2 times, most recently from eaf81fd to 0ac6b6b Compare April 9, 2024 01:22
@emteknetnz emteknetnz force-pushed the pulls/5/model-validation branch from 0ac6b6b to 8e8903c Compare April 9, 2024 01:23
maxime-rainville
maxime-rainville approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 2496b8f into silverstripe:5 Apr 15, 2024
3 checks passed
@maxime-rainville maxime-rainville deleted the pulls/5/model-validation branch April 15, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @GuySartorelli @maxime-rainville