Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: formatting error around list & wrong link #407

Closed
wants to merge 299 commits into from
Closed

Fix: formatting error around list & wrong link #407

wants to merge 299 commits into from

Conversation

cotpat
Copy link
Contributor

@cotpat cotpat commented Nov 24, 2023 •
edited
Loading

  • attempted to fix [info] tag around $Foo example list
  • attempted to fix link to formatting/casting section

(I say 'attempted' because I was unfortunately unable to succesfully build and serve the docs locally)

Maxime Rainville and others added 30 commits January 18, 2023 11:40
Merge pull request #135 from creative-commoners/pulls/5/htmlvalue
53be0f5 
DOC Removed HTMLValue shorthand
@emteknetnz
DOC parameter order
67aa583
@GuySartorelli
DOC Document changes to trailing slash in URLs
9482f5e
Merge pull request #138 from creative-commoners/pulls/5/param-order
a397d5f 
DOC parameter order
DOC Define what can be merge post beta
77c8932
@GuySartorelli
Merge pull request #136 from creative-commoners/pulls/5/trailing-slas…
6771a4a 
…h-docs

DOC Document changes to trailing slash in URLs
DOC List which classes had ReturnTypeWillChange annotation removed
4f1ad36
@maxime-rainville @GuySartorelli
Apply suggestions from code review
c021f5b 
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
@GuySartorelli
Merge pull request #140 from creative-commoners/pulls/5/beta-freaze
c658ed7 
DOC Define what can be merge post beta
@GuySartorelli
Merge pull request #132 from creative-commoners/pulls/5/returntypewil…
d23d34e 
…lchange

DOC List which classes had ReturnTypeWillChange annotation removed
@emteknetnz
DOC Update Email docs
6bef21e
@GuySartorelli
Merge pull request #143 from creative-commoners/pulls/5/email
b690160 
DOC Update Email docs
Merge branch '4' into 5
ac7c638
@GuySartorelli
DOC Document changes required to upgrade build stack (#137)
ac19d46
@GuySartorelli
DOC Document features from security-extensions
a9a435e
DOC New limit behaviour
a2e18b5
@maxime-rainville @sabina-talipova
Apply suggestions from code review
84e4827 
Co-authored-by: Sabina Talipova <87288324+sabina-talipova@users.noreply.github.com>
@sabina-talipova
Merge pull request #146 from creative-commoners/pulls/5/no-limit
1740e41 
Approve and merge
Merge branch '4' into 5
532996f
DOC Add supported module
1c42709
@sabina-talipova
Merge pull request #145 from creative-commoners/pulls/5/security-exte…
0d80844 
…nsions

DOC Document features from security-extensions
Apply feedback from peer review
c4f1aa5
Clean up a bunch of class references
6059447
Tweaks
fa9fe88
@maxime-rainville @GuySartorelli
Fix bad Github link by poiting to packagist instead.
5cc10ba 
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Mark beta changelog as unreleased.
4ff1354
Bring back line pointing the call for maintainers for some old TinyMC…
428d5a4 
…E plugin.
@maxime-rainville @GuySartorelli
Add missing backticks
e6f9da3 
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Link to contribution guideline.
283fb69
Remove failded builds that are now green.
1fa3b6b
GuySartorelli and others added 20 commits October 9, 2023 17:17
@GuySartorelli
Merge branch '5.0' into 5.1
4826b00
Merge pull request #355 from creative-commoners/pulls/5.1/clarificati…
1c81fee 
…on-about-benchmark

DOC Add clarification about benchmark results
@GuySartorelli
Merge branch '4.13' into 4
15b381a
@GuySartorelli
Merge branch '4' into 5.0
28ad128
@GuySartorelli
Merge branch '5.0' into 5.1
3f6b436
@GuySartorelli
MNT Added 5.1.0 changelog
7e4e4b8
@GuySartorelli
DOC Update eagerloading docs to explicitly say no relation filter (#376)
36f9313
@github-actions
Merge branch '4.13' into 4
e7990dd
@github-actions
Merge branch '4.13' into 4
4ed10c3
@GuySartorelli
Merge branch '4' into 5.1
067011b
@github-actions
Merge branch '4.13' into 4
3354dd2
@github-actions
Merge branch '4' into 5.1
f002554
@andrewandante
DOC Update 01_Code.md
951c9c8 
Fixes a few minor typos in "Contributing code" docs
@GuySartorelli
Merge pull request #386 from andrewandante/patch-1
cd522f2 
DOC Update 01_Code.md
@n8-dev
Update a example code comment
0033a97
DOC Remove references to old Addons website (#389)
5b23e3e
@github-actions
Merge branch '4.13' into 4
9e053ce
@github-actions
Merge branch '4' into 5.1
b08dd7e
@GuySartorelli
Merge pull request #392 from n8-dev/patch-2
6e7ba41 
Update a example code comment
@cotpat
Fix: formatting error around list & wrong link
9334270 
- attempted to fix [info] tag around $Foo example list
- attempted to fix link to formatting/casting section

(I say 'attempted' because I was unfortunately unable to build and serve the docs locally)
GuySartorelli
GuySartorelli reviewed Nov 25, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That info tag will need to be fixed in the renderer, or else it'll just happen again next time we put a list inside one of these blocks. Can you please raise an issue for it and remove that part from this PR?

Please also retarget this PR for the 4.13 branch, since the broken link is also present in the CMS 4 docs. You may need to reset your commits after retargetting the PR.

cotpat and others added 2 commits November 27, 2023 13:38
@cotpat @GuySartorelli
Update en/02_Developer_Guides/01_Templates/01_Syntax.md
e4c3cf9 
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
@cotpat
Update 01_Syntax.md
e6139a6
@cotpat cotpat changed the base branch from 5.1 to 4.13 November 27, 2023 12:40
@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 27, 2023 •
edited
Loading

@cotpat Thank you for changing the target branch - looks like you still need to reset your commits so we don't have all of the CMS 5 docs in the PR as well.
I'll mark this as a draft in the meantime.

@GuySartorelli GuySartorelli marked this pull request as draft November 27, 2023 20:00
@cotpat cotpat mentioned this pull request Nov 28, 2023
Merged
@cotpat
Copy link
Contributor Author

cotpat commented Nov 28, 2023

@GuySartorelli Thanks for the reminder. Unfortunately, I was unable to recreate the steps required to clean up this PR – sorry! Per the instructions, I created a new PR.

@GuySartorelli
Copy link
Member

Closing in favour of #410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.