DOC Mention that SS_TRUSTED_PROXY_IPS supports subnets #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Thanks for this addition, that's good context to have.
I've requested a couple of small changes below.
Please also retarget this to the 4.13 branch, unless this is not accurate for Silverstripe CMS 4,
Note that you may need to reset your commits after retargetting the PR.
Since SS_TRUSTED_PROXY_IPS uses IPUtils::checkIP, it is possible to specify subnets as well as individual IPs. This is important to know for AWS ALB. So it should be in the docs.
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
GuySartorelli
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SS_TRUSTED_PROXY_IPS uses IPUtils::checkIP, it is possible to specify subnets as well as individual IPs. This is important to know for AWS ALB. So it should be in the docs.