DOC Move orderBy docs to raw SQL section. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-314
to
-315
| Note that we've used the `orderBy()` method here. This is because `sort()` doesn't allow sorting by raw SQL, which is necessary to use a random sort. Be careful whenever you use the `orderBy()` method to ensure you don't pass in any values you can't trust. | ||
| [/warning] |
There was a problem hiding this comment.
Small question. Should we completely remove this statement or we could also move it in "Order by" section?
There was a problem hiding this comment.
Most of this is incorrectly saying you need to use raw SQL to do a random sort, but that's what the shuffle() method is for.
The rest of this is saying that raw SQL is inherently risky, which is already stated in the raw SQL section.
Basically, I don't think there's anything here that we need to keep.
sabina-talipova
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't encourage using
orderBy()for random sorting - that's what theshuffle()abstraction is for.Instead, don't mention
orderBy()at all until the dedicated raw SQL section.Issue
shuffle()instead oforderBy()#354