Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Add session-manager documentation #325

Closed
wants to merge 1 commit into from
Closed

DOC Add session-manager documentation #325

wants to merge 1 commit into from

Conversation

emteknetnz
Copy link
Member

Issue #322

@emteknetnz emteknetnz mentioned this pull request Aug 14, 2023
Closed
@emteknetnz emteknetnz force-pushed the pulls/5/session-manager-docs branch 2 times, most recently from 5e07192 to 4c1e922 Compare August 14, 2023 23:09
GuySartorelli
GuySartorelli requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few minor problems with links, but otherwise looks good.

Please target the 5.0 branch so this can take effect immediately.

@emteknetnz emteknetnz force-pushed the pulls/5/session-manager-docs branch from 4c1e922 to f57f4f2 Compare August 15, 2023 03:55
@emteknetnz emteknetnz force-pushed the pulls/5/session-manager-docs branch from f57f4f2 to 2457709 Compare August 15, 2023 03:59
@emteknetnz
Copy link
Member Author

closed in favour of #327

@emteknetnz emteknetnz closed this Aug 15, 2023
@GuySartorelli GuySartorelli deleted the pulls/5/session-manager-docs branch August 15, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli