-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Add missing 5.1 changelog notes #320
Merged
emteknetnz
merged 2 commits into
silverstripe:5
from
creative-commoners:pulls/5/missing-docs
Aug 14, 2023
Merged
DOC Add missing 5.1 changelog notes #320
emteknetnz
merged 2 commits into
silverstripe:5
from
creative-commoners:pulls/5/missing-docs
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Aug 14, 2023
en/04_Changelogs/5.1.0.md
Outdated
@@ -144,6 +145,7 @@ SilverStripe\ORM\DataList: | |||
- [`DataList::filterAny()`](api:SilverStripe\ORM\DataList::filterAny()) queries on many-many relations that use an aggregate `HAVING` clause now correctly use an `OR` conjunction rather than an incorrect `AND` conjunction. | |||
- At some point shortly before the release of Silverstripe CMS 4.0.0, SSL support for database connections was accidentally removed. This has now been reinstated - see [Using SSL in database connections](/developer_guides/security/secure_coding#using-ssl-in-database-connections) for more information. | |||
- The `cascade_duplicates` property was added to the [`InheritedPermissionsExtension`](api:SilverStripe\Security\InheritedPermissionsExtension) class so that now when duplicating any object that has the `InheritedPermissionsExtension` applied, the `GroupID` values in the `ViewerGroups` and `EditGroups` mapping tables will also be duplicated so that new object retains the same viewer and editor groups as the original. | |||
- And fields added to a model's `$summary_fields` configuration which are _not_ backed by database fields (such as method calls) will no longer be pulled through when `searchableFields()` calls back on it (i.e. because `$searchable_fields` configuration has not been explicitly declared). This means you do not need to explicitly declare `$searchable_fields` for models which should only use the summary fields to filter by. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- And fields added to a model's `$summary_fields` configuration which are _not_ backed by database fields (such as method calls) will no longer be pulled through when `searchableFields()` calls back on it (i.e. because `$searchable_fields` configuration has not been explicitly declared). This means you do not need to explicitly declare `$searchable_fields` for models which should only use the summary fields to filter by. | |
- Any fields added to a model's `$summary_fields` configuration which are _not_ backed by database fields (such as method calls) will no longer be pulled through when `searchableFields()` calls back on it (i.e. because `$searchable_fields` configuration has not been explicitly declared). This means you do not need to explicitly declare `$searchable_fields` for models which should only use the summary fields to filter by. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
3c74a29
to
6f0f2e5
Compare
emteknetnz
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue