Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add missing 5.1 changelog notes #320

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

GuySartorelli
Copy link
Member

@@ -144,6 +145,7 @@ SilverStripe\ORM\DataList:
- [`DataList::filterAny()`](api:SilverStripe\ORM\DataList::filterAny()) queries on many-many relations that use an aggregate `HAVING` clause now correctly use an `OR` conjunction rather than an incorrect `AND` conjunction.
- At some point shortly before the release of Silverstripe CMS 4.0.0, SSL support for database connections was accidentally removed. This has now been reinstated - see [Using SSL in database connections](/developer_guides/security/secure_coding#using-ssl-in-database-connections) for more information.
- The `cascade_duplicates` property was added to the [`InheritedPermissionsExtension`](api:SilverStripe\Security\InheritedPermissionsExtension) class so that now when duplicating any object that has the `InheritedPermissionsExtension` applied, the `GroupID` values in the `ViewerGroups` and `EditGroups` mapping tables will also be duplicated so that new object retains the same viewer and editor groups as the original.
- And fields added to a model's `$summary_fields` configuration which are _not_ backed by database fields (such as method calls) will no longer be pulled through when `searchableFields()` calls back on it (i.e. because `$searchable_fields` configuration has not been explicitly declared). This means you do not need to explicitly declare `$searchable_fields` for models which should only use the summary fields to filter by.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- And fields added to a model's `$summary_fields` configuration which are _not_ backed by database fields (such as method calls) will no longer be pulled through when `searchableFields()` calls back on it (i.e. because `$searchable_fields` configuration has not been explicitly declared). This means you do not need to explicitly declare `$searchable_fields` for models which should only use the summary fields to filter by.
- Any fields added to a model's `$summary_fields` configuration which are _not_ backed by database fields (such as method calls) will no longer be pulled through when `searchableFields()` calls back on it (i.e. because `$searchable_fields` configuration has not been explicitly declared). This means you do not need to explicitly declare `$searchable_fields` for models which should only use the summary fields to filter by.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@emteknetnz emteknetnz merged commit 2e073c8 into silverstripe:5 Aug 14, 2023
@emteknetnz emteknetnz deleted the pulls/5/missing-docs branch August 14, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants