Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC filterAny() many-many aggregate conjunction #266

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/5/aggregate-having branch from 70d6b1a to 7d296b4 Compare May 16, 2023 21:34
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth calling out the fact that you can now choose whether a subquery uses WHERE or HAVING?

@emteknetnz
Copy link
Member Author

Is it worth calling out the fact that you can now choose whether a subquery uses WHERE or HAVING?

I don't think so, seems like the subquery is a little piece of the ORM that isn't intended for anyone else to really interact with. It's just a think that's used to construct complex SQL statements behind the scenes

@GuySartorelli
Copy link
Member

I don't necessarily agree that it's not intended to be interacted with - I've used it in the past on various projects that needed deep ORM interactions. But I take the point that it's not a common use case. I'm okay with leaving that out.

@GuySartorelli GuySartorelli merged commit ab31d10 into silverstripe:5 May 17, 2023
@GuySartorelli GuySartorelli deleted the pulls/5/aggregate-having branch May 17, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants