Merge pull request #310 from creative-commoners/pulls/5/cve-2023-32302

[CVE-2023-32302] Require password field to be non-empty

en/04_Changelogs/5.1.0.md

@@ -6,6 +6,7 @@ title: 5.1.0 (unreleased)
 
 ## Overview
 
+- [Security considerations](#security-considerations)
 - [Features and enhancements](#features-and-enhancements)
   - [Eager loading](#eager-loading)
   - [GraphQL schema can be stored in `silverstripe-cache`](#gql-schema-is-cache)
@@ -16,6 +17,29 @@ title: 5.1.0 (unreleased)
 - [Dependency changes](#dependency-changes)
 - [Bug fixes](#bug-fixes)
 
+## Security considerations {#security-considerations}
+
+This release includes several security fixes. Review the individual vulnerability disclosure for more detailed descriptions of each security fix. We highly encourage upgrading your project to include the latest security patches.
+
+We have provided a severity rating of the vulnerabilities below based on the CVSS score. Note that the impact of each vulnerability could vary based on the specifics of each project. You can [read the severity rating definitions in the Silverstripe CMS release process](/contributing/release_process/#severity-rating).
+
+- [CVE-2023-32302 - Members with no password can be created and bypass custom login forms](https://www.silverstripe.org/download/security-releases/cve-2023-32302) Severity: Low
+  When a new `Member` record was created in the cms it was possible to set a blank password. If an attacker knows the email address of the user with the blank password then they can attempt to log in using an empty password. The default member authenticator, login form and basic auth all require a non-empty password, however if a custom authentication method is used it may allow a successful login with the empty password. Starting with this release, blank passwords are no no longer allowed when members are created in the CMS. Programatically created `Member` records, such as those used in unit tests, still allow blank passwords. You may have some `Member` records in your system already which have empty passwords. To detect these, you can loop over all `Member` records with `Member::get()` and pass each record into the below method. It might be sensible to create a [`BuildTask`](api:SilverStripe\Dev\BuildTask) for this purpose.
+  ```php
+    private function memberHasBlankPassword(Member $member): bool
+    {
+        // skip default admin as this is created programatically
+        if ($member->isDefaultAdmin()) {
+            return false;
+        }
+        // return true if a blank password is valid for this member
+        $authenticator = new MemberAuthenticator();
+        return $authenticator->checkPassword($member, '')->isValid();
+    }
+  ```
+  Once you have identified the records with empty passwords, it's up to you how to handle this. The most sensible way to resolve this is probably to generate a new secure password for each of these members, mark it as immediately expired, and email each affected member (assuming they have a valid email address in the system).
+
+
 ## Features and enhancements
 
 ### Eager loading
@@ -111,3 +135,4 @@ This release includes a number of bug fixes to improve a broad range of areas. C
 <!--- Changes below this line will be automatically regenerated -->
 
 <!--- Changes above this line will be automatically regenerated -->
+