Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

DEP Use PHPUnit 11 #3

Merged
merged 1 commit into from
Sep 18, 2024
Merged

DEP Use PHPUnit 11 #3

merged 1 commit into from
Sep 18, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Sep 12, 2024
Closed
2 tasks
GuySartorelli
GuySartorelli reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is master - will the affect CMS 5?

@emteknetnz
Copy link
Member Author

No, it's a dev requirement, so phpunit/phpunit version will be ignored and not installed when it's a requirement of something else

GuySartorelli
GuySartorelli approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge when all other PRs are approved

@GuySartorelli GuySartorelli merged commit 61a3912 into silverstripe:master Sep 18, 2024
@GuySartorelli GuySartorelli deleted the pulls/3.9/phpunit11 branch September 18, 2024 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli