Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suppress OneDiff logging if client code has already defined handlers in parent logger #888

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

rewbs
Copy link
Contributor

@rewbs rewbs commented May 19, 2024

With the current code, ConfigurableLogger.configure_logging() returns too soon if logging handlers are already defined in the parent logger.

If handlers are already defined, ConfigurableLogger should still set the OneDiff logging level and assign self.logger. The only step that should be skipped is setting up handlers (because the client code has already defined where logs should be sent).

@strint strint requested a review from ccssu May 21, 2024 10:20
@ccssu
Copy link
Contributor

ccssu commented May 30, 2024

git pull git@github.com:rewbs/onediff.git rewbs/upstream-log-fix

👋 Hello @rewbs , thank you for your pr in OneDiff , PR is not a problem, please format it pip install -U black==19.10b0 click==8.0.0 && python -m black src/onediff/infer_compiler/utils/log_utils.py

@strint
Copy link
Collaborator

strint commented Jul 9, 2024

@rewbs Very happy to get your PR. Please help to fix the conflict and I will merge it.

@strint strint self-requested a review July 9, 2024 07:20
@strint strint enabled auto-merge (squash) July 9, 2024 07:25
@strint strint merged commit e7ac789 into siliconflow:main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants