Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove useless using timestamp param after #333 #343

Merged
merged 1 commit into from
Mar 3, 2020
Merged

fix: remove useless using timestamp param after #333 #343

merged 1 commit into from
Mar 3, 2020

Conversation

melikhov-dev
Copy link
Contributor

I found some useless (after #333) using of third parameter timestamp in Gauge.prototype.set and Counter.prototype.inc functions and removed it.

@melikhov-dev melikhov-dev changed the title fix: remove useless setting timestamp after #333 fix: remove useless using timestamp param after #333 Mar 1, 2020
sam-github
sam-github approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siimon
Copy link
Owner

siimon commented Mar 3, 2020

👍

@siimon siimon merged commit 236a767 into siimon:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melikhov-dev @siimon @sam-github