-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced event loop monitoring not aggregated correctly across cluster #418
Comments
These are not entirely accurate: they're the "mean of the mean" and "mean of percentiles," but that's as good as we can get. Fixes siimon#418
Opened #422 if you'd like to give it a try or provide feedback! |
These are not entirely accurate: they're the "mean of the mean" and "mean of percentiles," but that's as good as we can get. Fixes siimon#418
Thanks for having looked into this. This actually went down in our priorities, as we actually moved away from using node cluster module. It also caused other problems with Prometheus metrics, e.g. causing random spikes in metrics when single cluster processes were restarted -- Maybe somebody else wants to give it a try? @dominathan seemed to be interested. :-) |
These are not entirely accurate: they're the "mean of the mean" and "mean of percentiles," but that's as good as we can get. Fixes siimon#418
These are not entirely accurate: they're the "mean of the mean" and "mean of percentiles," but that's as good as we can get. Fixes #418
Hi everybody,
could it be the the cluster support (#147) was overlooked when introducing the advanced event loop monitoring in #278?
The old event loop metric has an
aggregator
set, whereas all the new onen don't:prom-client/lib/metrics/eventLoopLag.js
Line 37 in c63689b
Was looking at some metrics of a node cluster today and couldn't quite make sense of it. It looks to me like something else than the default
sum
aggregator should be used for most the other lag metrics, right?The text was updated successfully, but these errors were encountered: