Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gauge.startTimer(labels) misses timestamp parameter #289

Closed
Sebi2020 opened this issue Sep 29, 2019 · 2 comments
Closed

gauge.startTimer(labels) misses timestamp parameter #289

Sebi2020 opened this issue Sep 29, 2019 · 2 comments

Comments

@Sebi2020
Copy link

It's not possible to set timestamps if you use gauges startTimer function.
@zbjornson
Copy link
Collaborator

See #177 - timestamps are actually incorrectly documented in this library and shouldn't be set on metrics. (Prometheus should be allowed to set that timestamp (the scrape time, not the event time) itself.)

This was referenced Feb 10, 2020
Closed
Merged
siimon pushed a commit that referenced this issue Feb 20, 2020
@sam-github
feature: remove all timestamp support (#333)
41c9523 
Fixes:
- #310
- #177
- #289
@SimenB
Copy link
Collaborator

SimenB commented Feb 22, 2020

#333

@SimenB SimenB closed this as completed Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zbjornson @SimenB @Sebi2020