sign: switch to P-256 #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is faster than P-384, is well-supported, and is well within security margins. Signed-off-by: William Woodruff <william@trailofbits.com>
haydentherapper
previously approved these changes
May 31, 2023
There was a problem hiding this comment.
Rekor doesn’t support ed25519 for hashedrekord because it requires the preimage, not the hash. See sigstore/rekor#1325 for a fix, haven’t had a chance to double check that’ll work.
Cool, thanks! I think the Python client will be blocked on ed25519-ph anyways due to Cryptography not supporting it (in part because OpenSSL in turn doesn't). |
Signed-off-by: William Woodruff <william@trailofbits.com>
di
previously approved these changes
Jun 5, 2023
Signed-off-by: William Woodruff <william@trailofbits.com>
di
approved these changes
Jun 7, 2023
lcordoui
pushed a commit
to lcordoui/sigstore-python
that referenced
this pull request
Jun 11, 2023
This is faster than P-384, is well-supported, and is well within security margins. Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster than P-384, is well-supported, and is well within security margins.
Longer term I'd like to switch to ed25519, but I'm having some trouble getting Rekor to accept
hashedrekordentries for ed25519 signatures.cc @alex