Implement sign command
#21
Conversation
SCT verification is not yet complete
|
@tetsuo-cpp I'll let you decide if we should lower or disable the coverage bar here, or try and add some very early tests. I think the former is fine as long as we come back later and test what we've got. |
| pass | ||
|
|
||
|
|
||
| def sign(file_, identity_token, output=_no_output): |
There was a problem hiding this comment.
I think we should figure out what the return type should be soon. I'm thinking something like a SigningResult which allows you to tell between success/failure and whether there is a reason.
We could also just not have a return and consider any non-throwing call to sign to be a success.
I'll go ahead and merge this anyway since we have too many pieces of work branched off this, but we should definitely revisit it.
There was a problem hiding this comment.
Agreed, although I don't think an empty return would work for anyone using this as an importable API, they'd want roughly the same things we're outputting (the signature and certificate) returned. I like the idea of a SigningResult.
Fixes #9.