Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the expected Sigstore CLI interface #32

Merged
merged 49 commits into from
Nov 9, 2022
Merged

Document the expected Sigstore CLI interface #32

merged 49 commits into from
Nov 9, 2022

Conversation

tetsuo-cpp
Copy link
Collaborator

Closes #11

tetsuo-cpp and others added 19 commits October 12, 2022 12:31
@tetsuo-cpp
Remove Docker infrastructure
995fa1d
@tetsuo-cpp
Create initial sigstore-conformance GitHub Action
4c38424
@tetsuo-cpp
Code documentation
b3a935c
@tetsuo-cpp
Fix test comment
5247870
@tetsuo-cpp
Add variable for debug logging
3b6d976
@tetsuo-cpp
Add linting to CI
7809f26
@tetsuo-cpp
Add selftest to conformance test sigstore-python
c3b1089
@tetsuo-cpp
Make action.py executable
38f1700
@tetsuo-cpp
Check in missing init file
3a584af
@tetsuo-cpp
Rename selftest job
c4c7ddb
@tetsuo-cpp
Use mypy and fix errors
e9a4448
@tetsuo-cpp
Make mypy ignore the pytest import
9caae33
@tetsuo-cpp
Reword entrypoint documentation
183091f
@tetsuo-cpp
Add README
dfdbf65
@tetsuo-cpp @woodruffw
Update README.md
4ef46b0 
Co-authored-by: William Woodruff <william@trailofbits.com>
@tetsuo-cpp
Move token permissions into selftest job
9150abd
@tetsuo-cpp
Merge branch 'alex/test-action' into alex/readme
2adf983
@tetsuo-cpp
Reformat README and adjust permissions guidance to be more restrictive
84b4013
@tetsuo-cpp
Add initial version of CLI protocol
d164700
@tetsuo-cpp tetsuo-cpp marked this pull request as draft October 13, 2022 13:59
@tetsuo-cpp
Copy link
Collaborator Author

I'm still thinking this over, but just thought I'd get your thoughts early.

tetsuo-cpp
tetsuo-cpp commented Oct 13, 2022
View reviewed changes
woodruffw
woodruffw reviewed Oct 13, 2022
View reviewed changes
woodruffw
woodruffw reviewed Oct 13, 2022
View reviewed changes
woodruffw
woodruffw reviewed Oct 13, 2022
View reviewed changes
woodruffw
woodruffw reviewed Oct 13, 2022
View reviewed changes
woodruffw
woodruffw reviewed Oct 13, 2022
View reviewed changes
woodruffw
woodruffw reviewed Oct 13, 2022
View reviewed changes
@woodruffw
Copy link
Member

This looks good to me overall! I left a handful of small nits, but the expected interface looks reasonable (and not burdensome for other implementations to comply with).

tetsuo-cpp
tetsuo-cpp commented Nov 2, 2022
View reviewed changes
@tetsuo-cpp tetsuo-cpp requested review from di and woodruffw November 2, 2022 13:06
@tetsuo-cpp tetsuo-cpp marked this pull request as ready for review November 2, 2022 13:07
@tetsuo-cpp
Copy link
Collaborator Author

The self-test is currently failing due to sigstore/sigstore-python#288 so we'll need to get that in first.

@woodruffw woodruffw mentioned this pull request Nov 9, 2022
Closed
woodruffw
woodruffw approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit a236384 into main Nov 9, 2022
@tetsuo-cpp tetsuo-cpp deleted the alex/cli-protocol branch November 9, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@di di Awaiting requested review from di

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the expected Sigstore CLI interface
2 participants
@tetsuo-cpp @woodruffw