Don't require a GitHub token #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new extremely-dangerous-public-oidc-beacon current-token branch allows us to fetch the JWT without a GitHub token. This makes local tests much nicer. Changes: * git clone the beacon repo to get the token * Do this in a loop until token is valid * Cache the token so we only do this once in a test run * Remove all mention of github token in arguments, comments and docs Some additional notes: * retry times are tweaked from the values upstream (and special values are set for the interactive case) * The caching could be smarter (could return cached value only if it's valid) but maybe this simple thing works? Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
This makes the test run significantly faster as well. That is just a result of the caching which we could have done with the previous approach as well so it's kind of unrelated. |
woodruffw
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new extremely-dangerous-public-oidc-beacon
current-tokenbranch allows us to fetch the JWT without a GitHub token. This makes local testing easy, which makes developing the suite easier.Changes:
Some additional notes:
Release Note
--github-tokenis no longer required to run signing tests