Tweak staging invocation #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally combined into a single invocation for convenience
but I believe this is more work than gain:
* xfails alone became painful if staging expected failures are not the
same as prod (which seems like a normal thing at times).
* The test results are much clearer ("Staging conformance failure" is
not as critical as "production conformance failure")
This means the caller does need to run the action twice to get both
tests
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
If we promise the order is static, let's make it something sensible (don't have --staging after the artifact input). Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
We already have --trusted-root that also is not always present. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
* Update config to current style * use "ruff check" instead of "ruff" Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Results should not change... except if infrastructure changes. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Makes sense to me, thanks for documenting! |
woodruffw
reviewed
Mar 14, 2024
woodruffw
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change here is the staging invocation: I'm proposing that a single action invocation only runs the testsuite once because
Other changes in this PR (from testing and reviewing for a hopefully near future release):
--stagingso it's not after the artifact filenameFixes #130
I'll mark William a reviewer since we originally agreed to run test suite twice but I think we may have been wrong.
For release Notes: