Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect docker-compose logs if sharding tests fail, also trim IDs #869

Merged
merged 5 commits into from
Jun 20, 2022

Conversation

bobcallaway
Copy link
Member

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner June 14, 2022 13:05
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from cpanato as a code owner June 14, 2022 14:46
Co-authored-by: Bob Callaway <bcallaway@google.com>
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #869 (29f9bc8) into main (45da1af) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
+ Coverage   46.24%   46.29%   +0.04%     
==========================================
  Files          60       60              
  Lines        5138     5137       -1     
==========================================
+ Hits         2376     2378       +2     
+ Misses       2487     2484       -3     
  Partials      275      275              
Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 53.30% <0.00%> (-1.24%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 48.84% <0.00%> (+0.66%) ⬆️
pkg/pki/x509/x509.go 56.92% <0.00%> (+0.67%) ⬆️
pkg/types/intoto/v0.0.1/entry.go 36.74% <0.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45da1af...29f9bc8. Read the comment docs.

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cpanato cpanato merged commit 85e60c5 into sigstore:main Jun 20, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants