Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print total tree size, including inactive shards in rekor-cli loginfo #864

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Jun 6, 2022

Signed-off-by: Priya Wadhwa priya@chainguard.dev

Summary

Ticket Link

Fixes

Release Note

BREAKING CHANGE: Rename `TreeSize` in `rekor-cli loginfo` output to `ActiveTreeSize`. This helps clarify that this is the length of the active tree. Also add in `TotalTreeSize`, which is the length of the entire log across all inactive and active shards.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa requested a review from a team as a code owner June 6, 2022 14:24
asraa
asraa previously approved these changes Jun 6, 2022
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

cmd/rekor-cli/app/log_info.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #864 (69f9690) into main (b2a5dca) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   46.46%   46.39%   -0.08%     
==========================================
  Files          60       60              
  Lines        5120     5128       +8     
==========================================
  Hits         2379     2379              
- Misses       2467     2475       +8     
  Partials      274      274              
Impacted Files Coverage Δ
cmd/rekor-cli/app/log_info.go 1.98% <0.00%> (-0.12%) ⬇️
pkg/types/helm/v0.0.1/entry.go 48.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a5dca...69f9690. Read the comment docs.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@asraa asraa merged commit 08d04c0 into sigstore:main Jun 7, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jun 7, 2022
@priyawadhwa priyawadhwa deleted the tree-size branch June 7, 2022 13:48
sfox-equinix added a commit to sfox-equinix/docs that referenced this pull request Jul 9, 2024
The "TreeSize" field was renamed to "ActiveTreeSize" in rekor
pull request 864. [1] This commit updates the single reference
to the old field name to match the current name.

References

1. sigstore/rekor#864

Signed-off-by: sfox-equinix <sfoxjr@equinix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants