Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure rekor server in e2e tests via env variable #850

Merged
merged 1 commit into from
May 31, 2022

Conversation

priyawadhwa
Copy link
Contributor

This way some of the e2e tests can be run against production to make sure it's running as expected. This will be useful for the upcoming cluster migration.

Signed-off-by: Priya Wadhwa priya@chainguard.dev

Summary

Ticket Link

Fixes

Release Note


This way the e2e tests can be run again production to make sure it's running as expected. This will be useful for the upcoming cluster migration.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa requested a review from a team as a code owner May 31, 2022 17:20
@codecov-commenter
Copy link

Codecov Report

Merging #850 (2485bc5) into main (d7e479a) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   46.36%   46.46%   +0.09%     
==========================================
  Files          60       60              
  Lines        5116     5116              
==========================================
+ Hits         2372     2377       +5     
+ Misses       2469     2465       -4     
+ Partials      275      274       -1     
Impacted Files Coverage Δ
pkg/types/rekord/v0.0.1/entry.go 48.84% <0.00%> (+0.66%) ⬆️
pkg/types/alpine/v0.0.1/entry.go 55.78% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e479a...2485bc5. Read the comment docs.

Copy link
Contributor

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@bobcallaway bobcallaway merged commit fc913fe into sigstore:main May 31, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants