Enable parsing of incomplete minisign keys, to enable re-indexing. #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b01c7b5 to
f1e3105
Compare
shibumi
reviewed
Dec 27, 2021
| if err != nil { | ||
| t.Errorf("%v: cannot open %v", tc.caseDesc, tc.inputFile) | ||
| } | ||
| t.Run(tc.caseDesc, func(t *testing.T) { |
There was a problem hiding this comment.
It might make sense to add more test cases in the tests slice above
There was a problem hiding this comment.
Or do we cover all added new functionality?
There was a problem hiding this comment.
Reorganized the tests a bit and added one more case!
f1e3105 to
7f88017
Compare
|
The coverage is now at 89% for that package, and 100% for the new code:
|
7f88017 to
ba5a5b6
Compare
shibumi
approved these changes
Dec 28, 2021
bobcallaway
reviewed
Dec 28, 2021
bobcallaway
approved these changes
Dec 28, 2021
ba5a5b6 to
687f838
Compare
Without this we can't properly re-run IndexKeys() on the log data because old minisign keys were stripped to no longer contain the KeyID or Algorithm field. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
687f838 to
5cb0be9
Compare
|
@bobcallaway merging the cover.out file is not necessart if we add gocoveralls or other coverage tooling to our CI pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this we can't properly re-run IndexKeys() on the log data because old minisign
keys were stripped to no longer contain the KeyID or Algorithm field.
Signed-off-by: Dan Lorenc lorenc.d@gmail.com
Summary
Ticket Link
Fixes
Release Note