Upload generated timestamps #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
pkg/api/timestamp.go
Outdated
| ProposedEntry: createRFC3161FromBytes(resp), | ||
| } | ||
|
|
||
| logEntry, code, msg, err := createLogEntry(ctx, entryParams) |
There was a problem hiding this comment.
I vaguely remember something about this being behind a flag like --log or something, not sure if we care about that anymore.
There was a problem hiding this comment.
Yeah, I think looking back on it we probably want all timestamps to be logged (even if only using as a timestamping machine) just for sake of transparency. But I'm open to creating a default upload flag and making it configurable per req.
|
LGTM. |
Signed-off-by: Asra Ali <asraa@google.com>
|
/request review from @bobcallaway. would love input on this "middleware chain" (really not sure if this was the best way) |
Signed-off-by: Asra Ali <asraa@google.com>
bobcallaway
reviewed
Jun 22, 2021
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @loosebazooka rekor stores RFC 3161 timestaps, so this PR adds create log entries whenever a timestamp is generated.
The output now looks like
Signed-off-by: Asra Ali asraa@google.com