-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dsse type #1487
add dsse type #1487
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
+ Coverage 66.48% 67.01% +0.53%
==========================================
Files 80 82 +2
Lines 8023 8325 +302
==========================================
+ Hits 5334 5579 +245
- Misses 2038 2077 +39
- Partials 651 669 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Fuzzing-part looks good! |
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this. Looking forward to using this in place of the intoto
type!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thank @bobcallaway! 🎉
Signed-off-by: Bob Callaway <bcallaway@google.com>
6f2041d
Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
@bobcallaway to confirm, is this the desired expectation for for all rekor entries or specific to the DSSE type? Rekor's search functionality, as well as its UI for viewing in-toto SLSA provenances positioned it as a useful tool for attestation discovery. |
Summary
This adds a new pluggable type
dsse
, which adds entries for DSSE JSON documents which are often used with in-toto attestations. There are a few significant differences between thisdsse
type and the already existingintoto
types:Release Note
dsse
which persisted information about DSSE envelopes without storing the envelope in RekorDocumentation