fix goroutine leak in client; add insecure TLS option

[bobcallaway]

This fixes a leaking goroutine (which comes from the underlying connection pool as noted at https://github.com/hashicorp/go-cleanhttp/blob/a0807dd79fc1680a7b1f2d5a2081d92567aab97d/cleanhttp.go#L19). In order to test this, we need to be able to use httptest with TLS enabled, which required enabling a client option for InsecureTLS connections.

Fixes: #1094

Signed-off-by: Bob Callaway bcallaway@google.com

[codecov-commenter]

Codecov Report

Merging #1238 (e2bff75) into main (81956e9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head e2bff75 differs from pull request most recent head b10c096. Consider uploading reports for the commit b10c096 to get more accurate results

@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
+ Coverage   63.35%   63.41%   +0.05%     
==========================================
  Files          82       82              
  Lines        7628     7639      +11     
==========================================
+ Hits         4833     4844      +11     
  Misses       2185     2185              
  Partials      610      610              

Flag	Coverage Δ
e2etests	47.87% <36.36%> (-0.02%)	⬇️
unittests	42.10% <100.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/client/options.go	100.00% <100.00%> (ø)
pkg/client/rekor_client.go	89.65% <100.00%> (+3.29%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.