Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selftest: skip alls-green if 3p PR #48

Merged
merged 1 commit into from
Feb 15, 2023
Merged

selftest: skip alls-green if 3p PR #48

merged 1 commit into from
Feb 15, 2023

Conversation

woodruffw
Copy link
Member

Unblocks #46.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested review from di and tetsuo-cpp February 15, 2023 20:50
@woodruffw
Copy link
Member Author

NB: This is needed because 3rd party PRs don't have access to the OIDC credential. With these, we skip the self-tests entirely, which then causes alls-green to unnecessarily fail.

@woodruffw woodruffw merged commit f3663a3 into main Feb 15, 2023
@woodruffw woodruffw deleted the ww/fix-selftests-3p branch February 15, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants