Export Fulcio extension OIDs #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls Fulcio OIDs into a global var so that they can be referenced by other libraries. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #761 +/- ##
==========================================
+ Coverage 54.05% 54.19% +0.14%
==========================================
Files 36 36
Lines 2257 2275 +18
==========================================
+ Hits 1220 1233 +13
- Misses 944 948 +4
- Partials 93 94 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
What do you think about putting this under its own package, so that clients don’t need to pull in the rest of the CA package? |
|
Works for me! I'll pull all the extension bits into its own package - we could use this to consolidate https://github.com/sigstore/cosign/blob/890cec1f43a8ec0754e0dd5a5d120847b63b6c4e/pkg/cosign/certextensions.go |
Refactors common certificate behavior into a distinct package. Adds ability to go to/from Extension type <-> []pkix.Extensions. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Replaced with pkg/certificates/extensions.go. Signed-off-by: Billy Lynch <billy@chainguard.dev>
haydentherapper
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pulls Fulcio OIDs into a global var so that they can be referenced by
other libraries.
Signed-off-by: Billy Lynch billy@chainguard.dev
Release Note
NONE
Documentation
NONE