Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work initializes the CT log client once and uses it for all requests instead of making a new one each time.
Thoughts for reviewers
The implementation here breaks from our current pattern of injecting dependencies by stuffing them into the request context. I think that explicit dependency inject makes it easier to reason about and test the code. This looks like explicitly asking for the API dependencies on construction and saving them in a struct so they can be accessed like that instead of pulling them out of the request context.
If ya'll agree that this pattern is more clear, I'm happy to iterate and do the same for the other API dependencies like the certificate authority backend and perhaps the logger. If not I'm happy to close this PR and fix using the context stuffing method instead.
Release Note