Set max request size to 4MiB #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3978f3 to
b840d7d
Compare
Signed-off-by: Nathan Smith <nathan@nfsmith.ca>
b840d7d to
11631b6
Compare
|
The diff algorithm made this one a little odd to read. Sorry ya'll 😅 |
dlorenc
approved these changes
Jan 21, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the the max request body size to 4MiB (Just a guess at a size.... may it could be smaller?) so that it isn't unbound. Implemented using a new
api.WithMaxBytesmiddleware. There is a small refactor of how we wire up stuff for the API server here as well to make it a little easier to understand. As adding the body limiting middleware was part of that wire up it seemed a good thing to clean up with this work.Ticket Link
Fixes #335
Release Note