Change ports for docker compose to avoid conflict with Rekor #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
This looks good! I don't know enough about docker compose to know off the top of my head, but would it be possible to share the same trillian instance between the two somehow? Something like a "shared service" that only gets spun up once? |
dlorenc
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working through issues with docker-compose. This is one of the simpler ones to resolve, which is changing the ports so that we can run both Rekor and Fulcio locally at the same time.
Other issues are plumbing through the GCP CA Service CA resource path without having to change the yaml, and there is an issue spinning up a local Dex service.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com