-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Root Cert method to the CA interface, and implement it. #287
Conversation
I don't really know if this is the best idea, but right now the ephemeral certs and the HSM stuff can be tricky to use if you don't remember the cert you loaded in. In the case of the GCP pools, the root certs can actually get created dynamically as well, with no way for anyone to know which are used. This is particularly important when automating setup with the CT log - where you need to configure the CT log with this set of certs. I'm open to other ideas here, just wanted to try this out as a prototype. |
This will make the ephemeral and HSM-based CAs easier to use, in addition to giving us an API to retrieve the existing root cert. This isn't available in-band today. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
I like this idea. CA Service implements something similar, FetchCaCerts. What do you think of changing the method from |
I thought about that - but would that work? The chain could vary per reach issued leaf, and we have a spot for that in the API already I think. Would it be something like "return the currently active chain"? |
Yea, the currently active chain. For previously issued certificates, like you said, you'd be able to verify as long as you've persisted the chain used to issue that cert. This would just be for clients that want the latest chain. |
Renamed so we can return them all! |
Fantastic! LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this to the client
and api_test.go
as well.
@dlorenc You mentioned you renamed the method, it doesn't look like that change got included? |
This will make the ephemeral and HSM-based CAs easier to use, in addition
to giving us an API to retrieve the existing root cert. This isn't available
in-band today.
Signed-off-by: Dan Lorenc lorenc.d@gmail.com
Summary
Ticket Link
Fixes
Release Note