Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing surplus slash, making logs richer #1762

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

javanlacerda
Copy link
Contributor

@javanlacerda javanlacerda commented Aug 13, 2024

Summary

During the validations, we noticed that the the template for source-repository-ref for gitlab has a surplus slash.
We also noticed that the error with log "value <> not present in either claims or defaults. has spawned several times in production, but we wasn't able to detect the reason for it, then I decided to put at least the issuer that triggered the flow on the error log.
I also added a validation that the metadata should exist for ci-providers.

Release Note

Documentation

cc @haydentherapper

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.26%. Comparing base (cf238ac) to head (040596e).
Report is 172 commits behind head on main.

Files Patch % Lines
pkg/identity/ciprovider/principal.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1762      +/-   ##
==========================================
- Coverage   57.93%   50.26%   -7.68%     
==========================================
  Files          50       70      +20     
  Lines        3119     4166    +1047     
==========================================
+ Hits         1807     2094     +287     
- Misses       1154     1841     +687     
- Partials      158      231      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javanlacerda javanlacerda force-pushed the javan.ci-provider-fixes branch 2 times, most recently from d35dcd8 to 9f6f3b4 Compare August 13, 2024 15:19
Signed-off-by: Javan lacerda <javanlacerda@google.com>
@javanlacerda javanlacerda force-pushed the javan.ci-provider-fixes branch from 9f6f3b4 to 436ee8e Compare August 13, 2024 19:44
pkg/identity/ciprovider/principal.go Outdated Show resolved Hide resolved
pkg/identity/ciprovider/principal.go Outdated Show resolved Hide resolved
pkg/identity/ciprovider/principal.go Outdated Show resolved Hide resolved
Signed-off-by: Javan lacerda <javanlacerda@google.com>
@javanlacerda javanlacerda force-pushed the javan.ci-provider-fixes branch from 8057502 to 89fa77a Compare August 13, 2024 20:20
Signed-off-by: Javan lacerda <javanlacerda@google.com>
@javanlacerda javanlacerda force-pushed the javan.ci-provider-fixes branch from 89fa77a to 0af7abc Compare August 13, 2024 20:21
@haydentherapper haydentherapper merged commit 9fd5c09 into sigstore:main Aug 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants