Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fulcio returns 200 if there's no RootCert #415

Closed
vaikas opened this issue Feb 16, 2022 · 1 comment · Fixed by #416
Closed

Fulcio returns 200 if there's no RootCert #415

vaikas opened this issue Feb 16, 2022 · 1 comment · Fixed by #416
Labels
bug Something isn't working

Comments

@vaikas
Copy link
Contributor

vaikas commented Feb 16, 2022

Description

Calling Fulcio to fetch rootCert returns 200 even if there's an error, it's just logged.
https://github.com/sigstore/fulcio/blob/main/pkg/api/ca.go#L242

This looks to caller like things worked, but then they'd have to verify the output in addition to error checking. We should return an error to the caller.

/assign vaikas
@vaikas vaikas added the bug Something isn't working label Feb 16, 2022
@nsmith5
Copy link
Contributor

nsmith5 commented Feb 16, 2022

Oh dear yeah there is no status setting anywhere there. There should also be a return statement under all the error handling so so we trundle onward after hitting errrors

vaikas added a commit to vaikas/fulcio that referenced this issue Feb 17, 2022
@vaikas
Return an error if we fail get get the Root cert.
1f811b0 
Fixes: sigstore#415

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas mentioned this issue Feb 17, 2022
Merged
vaikas added a commit to vaikas/fulcio that referenced this issue Feb 17, 2022
@vaikas
Return an error if we fail get get the Root cert.
5c066fe 
Fixes: sigstore#415

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
dlorenc pushed a commit that referenced this issue Feb 17, 2022
@vaikas
Return an error if we fail get get the Root cert. (#416)
167dcb1 
* Return an error if we fail get get the Root cert.

Fixes: #415

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>

* use a fake CA for testing

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return an error if we fail get get the Root cert. vaikas/fulcio
2 participants
@vaikas @nsmith5